Skip to content

Conversation

kacperzolkiewski
Copy link
Collaborator

Summary

Fixes: #2790

In setNativeProps all attributes except fill, stroke and style were passed through camelCaseToDashed. While this is correct for presentation attributes (e.g. strokeWidth → stroke-width) it breaks SVG attributes that are only valid in camelCase.

  • Added a whitelist (KEEP_CAMEL_CASE) of SVG attributes that must remain camelCase.
  • Updated setNativeProps to skip camelCaseToDashed for these attributes.

Test Plan

Run example from issue: #2790.
FeGaussianBlur animation should work properly.

Compatibility

OS Implemented
iOS
MacOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't animate on Web because of camelCase to dash conversion of Props

1 participant