fix: preserve camelCase for specific attributes in setNativeProps #2791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2790
In
setNativeProps
all attributes exceptfill
,stroke
andstyle
were passed throughcamelCaseToDashed
. While this is correct for presentation attributes (e.g.strokeWidth → stroke-width
) it breaks SVG attributes that are only valid in camelCase.KEEP_CAMEL_CASE
) of SVG attributes that must remain camelCase.setNativeProps
to skipcamelCaseToDashed
for these attributes.Test Plan
Run example from issue: #2790.
FeGaussianBlur
animation should work properly.Compatibility
Checklist
README.md
__tests__
folder